weizhouapache commented on a change in pull request #5730:
URL: https://github.com/apache/cloudstack/pull/5730#discussion_r759210196



##########
File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2764,6 +2770,21 @@ public Network doInTransaction(final TransactionStatus 
status) {
         return network;
     }
 
+    @Override
+    public boolean isSharedNetworkWithoutSpecifyVlan(NetworkOffering offering) 
{
+        if (offering == null || offering.getTrafficType() != TrafficType.Guest 
|| offering.getGuestType() != GuestType.Shared) {
+            return false;
+        }
+        if (! offering.isSpecifyVlan()) {

Review comment:
       @ravening done. thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to