shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798559105
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new
vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template,
hypervisorType, offering);
+ long volumesSize = isIso ? 0 :
configureCustomRootDiskSize(customParameters, template, hypervisorType,
offering);
Review comment:
@sureshanaparti do we need to consider even ISO size for resource limit
check done at line 3683? cc @DaanHoogland @rohityadavcloud @weizhouapache
I've made the change as VMs deployed using ISOs will always have root volume
created from the specified disk offering and ISO size shouldn't be considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
