shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798583477
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new
vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template,
hypervisorType, offering);
+ long volumesSize = isIso ? 0 :
configureCustomRootDiskSize(customParameters, template, hypervisorType,
offering);
Review comment:
I'm not completely sure if ISO will be copied to primary store. But even
if is and if the same ISO is used by 10 accounts to deploy a VM each, the
operator will end up charging them all for ISO size.
Better for now, leave it as it is, too big a change for 4.16.1 :D I'm
reverting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
