DaanHoogland commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798566755
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone,
ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new
vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template,
hypervisorType, offering);
+ long volumesSize = isIso ? 0 :
configureCustomRootDiskSize(customParameters, template, hypervisorType,
offering);
Review comment:
Makes sense from a logical viewpoint but as an operator, will the ISO
not also take its space on primary, i.e. will the user not have to be charged
for that space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
