BryanMLima commented on a change in pull request #6031:
URL: https://github.com/apache/cloudstack/pull/6031#discussion_r812965021



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtScaleVmCommandWrapper.java
##########
@@ -68,6 +71,23 @@ public Answer execute(ScaleVmCommand command, 
LibvirtComputingResource libvirtCo
         }
     }
 
+    /**
+     * Set the cpu_shares (priority) of the running VM. This is necessary 
because the priority is only calculated when deploying the VM.
+     * When the number of cores and/or speed of the CPU is changed the 
cpu_shares is only updated if the VM is restarted or manually, using the 
command schedinfo.

Review comment:
       It can be manually updated through the command mentioned in the PR 
description: `virsh schedinfo --domain <vm_internal_name> --live 
cpu_shares=<cpu_shares_value>` or restarting the VM. But I understand it is a 
bit confusing the way it is written, I will rewrite it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to