DaanHoogland commented on a change in pull request #6031:
URL: https://github.com/apache/cloudstack/pull/6031#discussion_r813010608
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtScaleVmCommandWrapper.java
##########
@@ -73,8 +73,7 @@ public Answer execute(ScaleVmCommand command,
LibvirtComputingResource libvirtCo
/**
* Sets the cpu_shares (priority) of the running VM. This is necessary
because the priority is only calculated when deploying the VM.
- * When the number of cores and/or speed of the CPU is changed the
cpu_shares is only updated if the VM is restarted or manually, using the
command schedinfo.
- * To correct this behaviour when live scaling, this command changes the
cpu_shares of a running VM.
+ * To prevent the cpu_shares to be manually updated by using the command
virsh schedinfo or restarting the VM. This method updates the cpu_shares of a
running VM on the fly.
Review comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
