rohityadavcloud commented on code in PR #6399:
URL: https://github.com/apache/cloudstack/pull/6399#discussion_r877878768
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2958,11 +2985,18 @@ private KVMPhysicalDisk
getPhysicalDiskPrimaryStore(PrimaryDataStoreTO primaryDa
protected void setDiskIoDriver(DiskDef disk) {
if (getHypervisorLibvirtVersion() >=
HYPERVISOR_LIBVIRT_VERSION_SUPPORTS_IO_URING
&& getHypervisorQemuVersion() >=
HYPERVISOR_QEMU_VERSION_SUPPORTS_IO_URING
- &&
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.ENABLE_IO_URING)) {
+ && isIoUringEnabled()) {
disk.setIoDriver(DiskDef.IoDriver.IOURING);
}
}
+ /**
+ * IO_URING supported if it is supported by qemu AND the property
'enable.io.uring' is set to true
+ */
+ private boolean isIoUringEnabled() {
+ return isIoUringSupportedByQemu() &&
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.ENABLE_IO_URING);
Review Comment:
Should this be `propertyValue || if-io-uring-is-supported()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
