NuxRo commented on code in PR #6399:
URL: https://github.com/apache/cloudstack/pull/6399#discussion_r877953220
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2949,6 +2949,33 @@ private KVMPhysicalDisk
getPhysicalDiskPrimaryStore(PrimaryDataStoreTO primaryDa
return storagePool.getPhysicalDisk(data.getPath());
}
+ /**
+ * Check if IO_URING is supported by qemu
+ */
+ protected boolean isIoUringSupportedByQemu() {
+ s_logger.debug("Checking if iouring is supported");
+ String command = getIoUringCheckCommand();
+ if (org.apache.commons.lang3.StringUtils.isBlank(command)) {
+ s_logger.debug("Could not check iouring support, disabling it");
+ return false;
+ }
+ int exitValue = executeBashScriptAndRetrieveExitValue(command);
+ return exitValue == 0;
+ }
+
+ protected String getIoUringCheckCommand() {
+ String[] qemuPaths = {"/usr/bin/qemu-system-x86_64",
"/usr/libexec/qemu-kvm", "/usr/bin/qemu-kvm" };
+ for (String qemuPath : qemuPaths) {
+ File file = new File(qemuPath);
+ if (file.exists()) {
+ String cmd = String.format("ldd %s | grep -Eqe
'[[:space:]]liburing\\.so'", qemuPath);
Review Comment:
@rohityadavcloud LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
