DaanHoogland commented on code in PR #6510:
URL: https://github.com/apache/cloudstack/pull/6510#discussion_r908135825
##########
engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java:
##########
@@ -572,7 +572,7 @@ public List<NetworkVO> listByPhysicalNetwork(final long
physicalNetworkId) {
public List<NetworkVO> listByPhysicalNetworkTrafficType(final long
physicalNetworkId, final TrafficType trafficType) {
final SearchCriteria<NetworkVO> sc = AllFieldsSearch.create();
sc.setParameters("trafficType", trafficType);
- sc.setParameters("physicalNetworkId", physicalNetworkId);
+ sc.setParameters("physicalNetwork", physicalNetworkId);
Review Comment:
this is strange, the field in both `NetworkVO` and in
`PhysicalNetworkTrafficType` is called `physicalNetworkId`. I would say the new
value is the typo. Do you know why this should work this way @GutoVeronezi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
