[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6510: Fix API deleteTrafficType not filtering physical network

Tue, 28 Jun 2022 06:01:17 -0700 


DaanHoogland commented on code in PR #6510:
URL: https://github.com/apache/cloudstack/pull/6510#discussion_r908451270


##########
engine/schema/src/main/java/com/cloud/network/dao/NetworkDaoImpl.java:
##########
@@ -572,7 +572,7 @@ public List<NetworkVO> listByPhysicalNetwork(final long 
physicalNetworkId) {
     public List<NetworkVO> listByPhysicalNetworkTrafficType(final long 
physicalNetworkId, final TrafficType trafficType) {
         final SearchCriteria<NetworkVO> sc = AllFieldsSearch.create();
         sc.setParameters("trafficType", trafficType);
-        sc.setParameters("physicalNetworkId", physicalNetworkId);
+        sc.setParameters("physicalNetwork", physicalNetworkId);

Review Comment:
   yes, you are right, very confusing, but I shouldn´t rely on naming 
conventions ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to