weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062365397
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final
TransactionStatus status) {
detailsVO.add(new
NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol,
String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
`saveDetails` will firstly remove all existing details. this causes issue
(2) in the PR decription.
in my opinion. the issue is critical . @DaanHoogland @rohityadavcloud
@shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
