weizhouapache commented on code in PR #7057:
URL: https://github.com/apache/cloudstack/pull/7057#discussion_r1062406906
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -6408,7 +6408,9 @@ public NetworkOfferingVO doInTransaction(final
TransactionStatus status) {
detailsVO.add(new
NetworkOfferingDetailsVO(offering.getId(), Detail.internetProtocol,
String.valueOf(internetProtocol), true));
}
if (!detailsVO.isEmpty()) {
- networkOfferingDetailsDao.saveDetails(detailsVO);
Review Comment:
> @weizhouapache this is used while creating a new offering so will it
matter even if the code tries to delete existing details for the resourceId
(service offering is here)?
@shwstppr yes, there are some network offering details passed via API.
https://cloudstack.apache.org/api/apidocs-4.17/apis/createNetworkOffering.html
for example, the following details are not saved
Promiscuous mode
MAC address changes
Forged transmits
MAC learning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
