shwstppr commented on code in PR #7272:
URL: https://github.com/apache/cloudstack/pull/7272#discussion_r1112958080
##########
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java:
##########
@@ -104,7 +104,16 @@ private boolean addGuestOs(long categoryId, String
displayName) {
}
public void addGuestOsHypervisorMapping(GuestOSHypervisorMapping mapping,
long guestOsId) {
- if(!isValidGuestOSHypervisorMapping(mapping)) {
+ if (!isValidGuestOSHypervisorMapping(mapping)) {
+ return;
+ }
+ if (guestOSDao.findById(guestOsId) == null) {
+ LOG.debug(String.format("Skipping adding guest OS hypervisor
mapping - %s as guest OS ID: %d not preset", mapping, guestOsId));
Review Comment:
```suggestion
LOG.debug(String.format("Skipping adding guest OS hypervisor
mapping - %s as guest OS ID: %d not present", mapping, guestOsId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
