borisstoyanov commented on code in PR #7272:
URL: https://github.com/apache/cloudstack/pull/7272#discussion_r1112954912
##########
engine/schema/src/main/java/com/cloud/upgrade/GuestOsMapper.java:
##########
@@ -104,7 +104,16 @@ private boolean addGuestOs(long categoryId, String
displayName) {
}
public void addGuestOsHypervisorMapping(GuestOSHypervisorMapping mapping,
long guestOsId) {
- if(!isValidGuestOSHypervisorMapping(mapping)) {
+ if (!isValidGuestOSHypervisorMapping(mapping)) {
Review Comment:
I'm currently testing it, but I'm fine with the logic.
as far as I get it goes that if the main OS is not there, it will skip to
make a reference for the hypervisor. This will potentially evade us from any of
such cases, but it also remains for the users to manage the guestos mappings.
@DaanHoogland thoughs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
