phsm commented on PR #7293: URL: https://github.com/apache/cloudstack/pull/7293#issuecomment-1446191247
Hi Wei, We have found this inconsistency while debugging some other issue that turned out to be unrelated to this piece of code. So in short: there is no reproduce scenario, besides our suspicion that these lines **may** introduce bugs. The generateRulesetCmd() is used to generate a set of firewall rules for a vNIC. It currently uses the private_mac_address VM field which contains a single MAC address that I believe belongs to the latest vNIC of the VM. Thus, it would be logical that this function should use the MAC address of the vNIC it is creating a firewall rule for. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
