phsm commented on PR #7293: URL: https://github.com/apache/cloudstack/pull/7293#issuecomment-1446229364
> on first sight this looks good, but it raises more questions when you think of it. Most significantly, > > 1. Why is this implemented twice? Should this not be a single place that does this (and even a single `SecurityGroupMnagerImpl` instead of two.) > > 2. if we can not reproduce than how do we know this doesn´t have side effects or removes side effects that we need. > I am a bit worried, but again, looks good on first sight. 1. Not sure, perhaps legacy vs modern implementation? I'm not sure how to check which of these 2 files is actually used somewhere else. 2. Yes this is the tricky part. Perhaps @weizhouapache knows more of the mac address purpose in "security_group.py" script? He's AFAIK the last person who made major changes there (additional IP addresses for a VM feature). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
