DaanHoogland commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1221168973
##########
test/integration/smoke/test_kubernetes_clusters.py:
##########
@@ -622,11 +704,10 @@ def createKubernetesCluster(self, name, version_id,
size=1, control_nodes=1):
createKubernetesClusterCmd.noderootdisksize = 10
createKubernetesClusterCmd.account = self.account.name
createKubernetesClusterCmd.domainid = self.domain.id
+ createKubernetesClusterCmd.clustertype = cluster_type
if self.default_network:
createKubernetesClusterCmd.networkid = self.default_network.id
clusterResponse =
self.apiclient.createKubernetesCluster(createKubernetesClusterCmd)
- if not clusterResponse:
- self.cleanup.append(clusterResponse)
Review Comment:
ok, makes sense, but
@shwstppr the cluster is created here and so it should be destroyed here, or
its creation should be moved to class-scope or higher.
@vishesh92 I think it might be worth adding a base.lib entry for clusters,
but ... as said, this is a bit of scope creep. It might however explain the
spurious failures on k8s we see in tests runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
