DaanHoogland commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1221148995
##########
test/integration/smoke/test_kubernetes_clusters.py:
##########
@@ -622,11 +704,10 @@ def createKubernetesCluster(self, name, version_id,
size=1, control_nodes=1):
createKubernetesClusterCmd.noderootdisksize = 10
createKubernetesClusterCmd.account = self.account.name
createKubernetesClusterCmd.domainid = self.domain.id
+ createKubernetesClusterCmd.clustertype = cluster_type
if self.default_network:
createKubernetesClusterCmd.networkid = self.default_network.id
clusterResponse =
self.apiclient.createKubernetesCluster(createKubernetesClusterCmd)
- if not clusterResponse:
- self.cleanup.append(clusterResponse)
Review Comment:
if we remove this here , we need to add it in the calling method(s).
Alternative to muy suggestion
(https://github.com/apache/cloudstack/pull/7515/files#r1217636578) we can
validate the response here and on success add the cluster to self.cleanup here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
