rohityadavcloud commented on code in PR #7810:
URL: https://github.com/apache/cloudstack/pull/7810#discussion_r1283166526
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2780,15 +2780,10 @@ protected GuestResourceDef
createGuestResourceDef(VirtualMachineTO vmTO){
grd.setMemBalloning(!_noMemBalloon);
- long maxRam = ByteScaleUtils.bytesToKibibytes(vmTO.getMaxRam());
- long currRam = vmTO.getType() == VirtualMachine.Type.User ?
getCurrentMemAccordingToMemBallooning(vmTO, maxRam) : maxRam;
-
- if (s_logger.isTraceEnabled()) {
- s_logger.trace(String.format("memory values for VM %s are
%d/%d",vmTO.getName(),maxRam, currRam));
- }
+ Long maxRam = ByteScaleUtils.bytesToKibibytes(vmTO.getMaxRam());
grd.setMemorySize(maxRam);
- grd.setCurrentMem(currRam);
+ grd.setCurrentMem(getCurrentMemAccordingToMemBallooning(vmTO, maxRam));
Review Comment:
I just realised the maxRam seetting is fixed as in the KVMGuru the correct
maxRam is passed now.
cc @DaanHoogland @weizhouapache let's test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
