rohityadavcloud commented on PR #7810: URL: https://github.com/apache/cloudstack/pull/7810#issuecomment-1664292430
I did whole lot of testing; the VM ballooning feature isn't dynamic or automatic like I thought earlier and the only feasible feature is to have dynamic scaling of VMs (that's manual); so as a best compromise this PR tries to do the following; 1. Pass the maxMem to KVMGuru that sends the right max. memory to KVM agent 2. When memory ballooning is disable or when the VM isn't a User VM, then use the maxMemory (new/tweaked behaviour) 3. When memory balloning is enabled and VM is a User VM type, then use min memory (old behaviour) Ideally I think the ballooning feature should be disabled esp if overcommit is used; and use should log or document such as case for operators/users to be aware of (i.e. what to expect from the memory ballooning feature in case of KVM, and its behaviour with memory overcommit enabled). @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
