rohityadavcloud commented on PR #7810: URL: https://github.com/apache/cloudstack/pull/7810#issuecomment-1665249761
Thanks @DaanHoogland if you see my comment, we need not re-open the previous issue. Ask @weizhouapache to review and lgtm/advise; This PR handles the following cases: 1. Doc PR addresses what to expect, what/how to configure KVM host env when overcommiting memory - https://github.com/apache/cloudstack-documentation/pull/337 2. For non-User VMs, we use max memory and in KVM guru the correct max memory is passed (fixes #7443) 3. Fixes #7794 as centos7/el7 smoketests passing now https://github.com/apache/cloudstack/pull/7810#issuecomment-1664869520 4. Reverts/ensures we don't disable memory balloon feature for KVM I think this covers most of the cases and doc PR handles advising users the best practice they deem fit for what they're doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
