DaanHoogland commented on code in PR #7810:
URL: https://github.com/apache/cloudstack/pull/7810#discussion_r1284154489
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2800,11 +2795,17 @@ protected GuestResourceDef
createGuestResourceDef(VirtualMachineTO vmTO){
}
protected long getCurrentMemAccordingToMemBallooning(VirtualMachineTO
vmTO, long maxRam) {
- if (_noMemBalloon) {
- s_logger.warn(String.format("Setting VM's [%s] current memory as
max memory [%s] due to memory ballooning is disabled. If you are using a custom
service offering, verify if memory ballooning really should be disabled.",
vmTO.toString(), maxRam));
+ if (_noMemBalloon || (vmTO != null && vmTO.getType() !=
VirtualMachine.Type.User)) {
Review Comment:
ok, looks good and let's merge. I'll test that scenario anyway in the env I
am building right now;
https://github.com/apache/cloudstack/pull/7810#issuecomment-1665188783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
