weizhouapache commented on code in PR #8058: URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350485058
########## .github/workflows/sonar-check.yml: ########## @@ -28,7 +28,7 @@ concurrency: jobs: build: - if: github.repository == 'apache/cloudstack' + if: github.repository == 'apache/cloudstack' && github.event.pull_request.head.repo.full_name == github.repository Review Comment: if so, users need to configure sonar token in github project. For example, if someone creates a PR in shapeblue (forked) repositories, currently the sonar check is skipped. But with this change, sonar check will not be skipped, but fail (as sonar token does not exist in project settings). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
