weizhouapache commented on code in PR #8058:
URL: https://github.com/apache/cloudstack/pull/8058#discussion_r1350591077


##########
.github/workflows/sonar-check.yml:
##########
@@ -28,7 +28,7 @@ concurrency:
 
 jobs:
   build:
-    if: github.repository == 'apache/cloudstack'
+    if: github.repository == 'apache/cloudstack' && 
github.event.pull_request.head.repo.full_name == github.repository

Review Comment:
   yes. so between these 2 options with forks
   - enable PR sonar check by default. users need to disable it by code changes 
if they do not have sonar token.
   - disable PR sonar check by default. users need to enable it by code changes 
if they have sonar token.
   
   the PR sonar check was disabled on forks by #7199 
   we can change the behaviour if needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to