vishesh92 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1350725760


##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##########
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd extends BaseCmd {
 
     @Override
     public void execute() {
+        CallContext.current().setEventDetails(String.format("Tariff: %s, 
description: %s, value: %s", getName(), getDescription(), getValue()));

Review Comment:
   IMO, It would be better to override `getApiResourceType()` & 
`getApiResourceId() ` methods. This would also link the events with the quota 
resources.
   
   @harikrishna-patnala @DaanHoogland What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to