vishesh92 commented on code in PR #8030:
URL: https://github.com/apache/cloudstack/pull/8030#discussion_r1351622203


##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaTariffCreateCmd.java:
##########
@@ -70,6 +71,7 @@ public class QuotaTariffCreateCmd extends BaseCmd {
 
     @Override
     public void execute() {
+        CallContext.current().setEventDetails(String.format("Tariff: %s, 
description: %s, value: %s", getName(), getDescription(), getValue()));

Review Comment:
   No. I meant for Quota resource itself. Here is the javadoc for 
`getApiResourceId()` method.
   This will require adding a key `ApiCommandResourceType.java` as well.
   ```java
   /**
        * Commands that generate action events associated to a resource and
        * async commands that want to be tracked as part of the listXXX commands
        * need to provide implementations of the two following methods,
        * getApiResourceId() and getApiResourceType()
        *
        * getApiResourceId() should return the id of the object the async 
command is executing on
        * getApiResourceType() should return a type from the 
ApiCommandResourceType enumeration
        */
   ```
   As per my understanding, this will add a link in UI for events view. And 
allows to filter events per resource type & resource id which is quota in this 
case.
   
![image](https://github.com/apache/cloudstack/assets/8760112/acb11387-52f9-47d7-9e0d-619f077fb691)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to