rg9975 commented on code in PR #7889:
URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1352636235
##########
server/src/main/java/com/cloud/server/StatsCollector.java:
##########
@@ -1620,7 +1620,9 @@ protected void runInContext() {
for (StoragePoolVO pool : pools) {
List<VolumeVO> volumes =
_volsDao.findByPoolId(pool.getId(), null);
for (VolumeVO volume : volumes) {
- if (volume.getFormat() != ImageFormat.QCOW2 &&
volume.getFormat() != ImageFormat.VHD && volume.getFormat() != ImageFormat.OVA
&& (volume.getFormat() != ImageFormat.RAW || pool.getPoolType() !=
Storage.StoragePoolType.PowerFlex)) {
+ if (volume.getFormat() != ImageFormat.QCOW2 &&
volume.getFormat() != ImageFormat.VHD &&
+ volume.getFormat() != ImageFormat.OVA &&
pool.getPoolType() != Storage.StoragePoolType.PowerFlex &&
+ pool.getPoolType() !=
Storage.StoragePoolType.FiberChannel) {
Review Comment:
Only if its FiberChannel or PowerFlex. I simply extended what was done for
Powerflex in this case. The stats data is available from the storage provider
in the case of Primera and Pure. I suspect its available for other types of
storage providers. This code probably should be refactored to use the storage
provider in some way instead of trying to determine the information by looking
at the format, but I did not want to get into a more extension change at this
time to try to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
