rg9975 commented on code in PR #7889:
URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1352862984
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##########
@@ -1684,7 +1730,40 @@ private CopyCmdAnswer copyImageToVolume(DataObject
srcDataObject, VolumeInfo des
* If the storage system is using writable snapshots, then nothing need be
done by that storage system here because we can just
* resign the SR and the VDI that should be inside of the snapshot before
copying the VHD file to secondary storage.
*/
+ @Inject
+ private VolumeDataFactory _volFactory;
private void createVolumeFromSnapshot(SnapshotInfo snapshotInfo) {
+ // use normal volume semantics (create a volume known to cloudstack,
ask the storage driver to create it as a copy of the snapshot)
Review Comment:
fixed in upcoming commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
