DaanHoogland commented on code in PR #8082:
URL: https://github.com/apache/cloudstack/pull/8082#discussion_r1356847320
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -197,6 +197,10 @@ public boolean deleteStoragePool(KVMStoragePool pool) {
return deleteStoragePool(pool.getUuid());
}
+ /**
+ * createPhysicalDisk will check if the resource wasn't yet created and do
so, also it will make sure
+ * it is accessible from this node (MakeAvailable).
+ */
Review Comment:
should this javadoc be on the interface?
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -228,7 +232,11 @@ public KVMPhysicalDisk createPhysicalDisk(String name,
KVMStoragePool pool, Qemu
null,
null);
- // TODO make available on node
+ ResourceMakeAvailable rma = new ResourceMakeAvailable();
+ rma.diskful(true);
+ ApiCallRcList answers = api.resourceMakeAvailableOnNode(rscName,
localNodeName, rma);
+ handleLinstorApiAnswers(answers,
+ String.format("Linstor: Unable to make resource %s available
on node: %s", rscName, localNodeName));
Review Comment:
separate method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
