rp- commented on code in PR #8082:
URL: https://github.com/apache/cloudstack/pull/8082#discussion_r1356862954
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -197,6 +197,10 @@ public boolean deleteStoragePool(KVMStoragePool pool) {
return deleteStoragePool(pool.getUuid());
}
+ /**
+ * createPhysicalDisk will check if the resource wasn't yet created and do
so, also it will make sure
+ * it is accessible from this node (MakeAvailable).
+ */
Review Comment:
I don't think so, as I guess other `createPhysicalDisk()` calls might just
create the actual disk, but not check before if it is necessary.
Just wanted that to be documented somewhere, maybe I also got your question
wrong and I should move the comment in the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
