soreana commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1365455137
##########
engine/schema/src/main/java/com/cloud/network/dao/NetworkDetailsDao.java:
##########
@@ -16,10 +16,26 @@
// under the License.
package com.cloud.network.dao;
+import java.util.Map;
+import java.util.List;
+
import org.apache.cloudstack.resourcedetail.ResourceDetailsDao;
import com.cloud.utils.db.GenericDao;
public interface NetworkDetailsDao extends GenericDao<NetworkDetailVO, Long>,
ResourceDetailsDao<NetworkDetailVO> {
Review Comment:
`ResourceDetailsDaoBase` is an abstract class, it can not be parent of an
interface. Shall I make NetworkDetailsDao abstract class as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
