soreana commented on PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1777180110
> NetworkDetailVO
@weizhouapache The `NetworkDetailVO` in the following locations have been
used, it is possible to list/update/remove a `NetworkDetailVO` using
`NetworkDetailsDao`.
They
> @soreana left some comments
>
> currently `NetworkDetailsDao` is used in some java classes.
>
> ```
> $ git grep 'new NetworkDetailVO'
>
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
NetworkDetailVO detailVO = new
NetworkDetailVO(networkPersisted.getId(), ApiConstants.ISOLATED_PVLAN_TYPE,
network.getPvlanType().toString(), true);
>
engine/schema/src/main/java/com/cloud/network/dao/NetworkDetailsDaoImpl.java:
super.addDetail(new NetworkDetailVO(resourceId, key, value, display));
>
plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenServiceImpl.java:
NetworkDetailVO networkDetailVO = new
NetworkDetailVO(publicNetwork.getId(), "vrf",
>
plugins/network-elements/tungsten/src/main/java/org/apache/cloudstack/network/tungsten/service/TungstenServiceImpl.java:
networkDetailVO = new NetworkDetailVO(network.getId(), "vrf",
> server/src/main/java/com/cloud/network/NetworkMigrationManagerImpl.java:
_networkDetailsDao.persist(new NetworkDetailVO(dstNetworkId,
networkDetail.getName(), networkDetail.getValue(), networkDetail.isDisplay()));
> server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
_networkDetailsDao.persist(new NetworkDetailVO(network.getId(),
Network.hideIpAddressUsage, String.valueOf(hideIpAddressUsage), false));
> server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
_networkDetailsDao.persist(new NetworkDetailVO(network.getId(),
Network.AssociatedNetworkId, String.valueOf(associatedNetwork.getId()), true));
> server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
_networkDetailsDao.persist(new NetworkDetailVO(network.getId(),
Network.hideIpAddressUsage, hideIpAddressUsage.toString(), false));
> server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
NetworkDetailVO networkDetail = new NetworkDetailVO(network.getId(),
Network.updatingInSequence, "true", true);
> server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
_networkDetailsDao.persist(new
NetworkDetailVO(privateNetwork.getId(), Network.AssociatedNetworkId,
String.valueOf(associatedNetworkId), true));
> ```
>
> Please take it into consideration. e.g. can the details be
listed/updated/removed ?
@weizhouapache I couldn't check the Tungsten fabric but looking at the code
there shouldn't be a problem, when the details are added there is also a
mechanism to delete it.
In `NetworkOrchestrator` it adds virtual router public ip as a network
details in the following lines however that details never stored in the db. I'm
checking to see if it is a deviation of my PR or it was always like this.
https://github.com/apache/cloudstack/blob/543c54c7189937fe15e2c74db2277795e13a7a1c/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L801-L803
https://github.com/apache/cloudstack/blob/543c54c7189937fe15e2c74db2277795e13a7a1c/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L712-L719
```sql
MariaDB [cloud]> select * from network_details;
Empty set (0.001 sec)
MariaDB [cloud]>
```
I haven't check the reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
