weizhouapache commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1777368030
> > > > Please take it into consideration. e.g. can the details be listed/updated/removed ? > > @weizhouapache I couldn't check the Tungsten fabric but looking at the code there shouldn't be a problem, when the details are added there is also a mechanism to delete it. > > In `NetworkOrchestrator` it adds virtual router public ip as a network details in the following lines however that details never stored in the db. I'm checking to see if it is a deviation of my PR or it was always like this. > > https://github.com/apache/cloudstack/blob/543c54c7189937fe15e2c74db2277795e13a7a1c/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L801-L803 > > https://github.com/apache/cloudstack/blob/543c54c7189937fe15e2c74db2277795e13a7a1c/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java#L712-L719 > > ```sql > MariaDB [cloud]> select * from network_details; > Empty set (0.001 sec) > > MariaDB [cloud]> > ``` > > I haven't check the reset yet. @soreana thanks for checking. my concern is, should we manage (list/update/delete) the network details above via API as well? currently they are managed by some internal processes in cloudstack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
