shwstppr commented on code in PR #8222:
URL: https://github.com/apache/cloudstack/pull/8222#discussion_r1390663709
##########
api/src/main/java/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java:
##########
@@ -46,10 +46,13 @@ public class DisassociateIPAddrCmd extends BaseAsyncCmd {
//////////////// API parameters /////////////////////
/////////////////////////////////////////////////////
- @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
IPAddressResponse.class, required = true, description = "the ID of the public
IP address"
+ @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType =
IPAddressResponse.class, description = "the ID of the public IP address"
+ " to disassociate")
private Long id;
+ @Parameter(name=ApiConstants.IP_ADDRESS, type=CommandType.STRING,
description="IP Address to be disassociated")
Review Comment:
```suggestion
@Parameter(name=ApiConstants.IP_ADDRESS, type=CommandType.STRING,
description="IP Address to be disassociated", since="4.19.0")
```
Would be good to add since property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
