abh1sar commented on code in PR #8222:
URL: https://github.com/apache/cloudstack/pull/8222#discussion_r1391181762
##########
api/src/main/java/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java:
##########
@@ -59,7 +62,14 @@ public class DisassociateIPAddrCmd extends BaseAsyncCmd {
/////////////////////////////////////////////////////
public Long getIpAddressId() {
- return id;
+ if (id != null) {
Review Comment:
ID is taking the precedence implicitly, as it is checked first. But this
creates problem if the user gives both parameters but the ipaddress is some
random value. Then also the api passes by deleting the ipaddress associated
with the ID. I think we can throw an exception in that case (if the address is
not the same as pointed to by the ID).
How do I make it explicit that the ID takes precedence?
"the descriptions need to point out that both parameters are exclusive."
Can you please elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
