abh1sar commented on code in PR #8222:
URL: https://github.com/apache/cloudstack/pull/8222#discussion_r1391204553
##########
api/src/main/java/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java:
##########
@@ -59,7 +62,14 @@ public class DisassociateIPAddrCmd extends BaseAsyncCmd {
/////////////////////////////////////////////////////
public Long getIpAddressId() {
- return id;
+ if (id != null) {
Review Comment:
Sure, so should I throw an exception as well if both parameters are
provided? I think that would be simpler and clear in this case as well.
Otherwise we have to make sure that both are pointing to the same entity.
Also, do you have an example in mind of any other api like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
