DaanHoogland commented on code in PR #8222:
URL: https://github.com/apache/cloudstack/pull/8222#discussion_r1391188144
##########
api/src/main/java/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java:
##########
@@ -59,7 +62,14 @@ public class DisassociateIPAddrCmd extends BaseAsyncCmd {
/////////////////////////////////////////////////////
public Long getIpAddressId() {
- return id;
+ if (id != null) {
Review Comment:
The convention in the system now, is to check and throw an exception if both
are present. not saying it is the best way, just the usual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
