winterhazel commented on code in PR #8713:
URL: https://github.com/apache/cloudstack/pull/8713#discussion_r1506293262
##########
ui/src/views/compute/InstanceTab.vue:
##########
@@ -33,7 +33,7 @@
<router-link :to="{ path: '/iso/' + vm.isoid }">{{ vm.isoname
}}</router-link> <br/>
<barcode-outlined /> {{ vm.isoid }}
</a-tab-pane>
- <a-tab-pane :tab="$t('label.volumes')" key="volumes">
+ <a-tab-pane :tab="$t('label.volumes')" key="volumes" v-if="'listVolumes'
in $store.getters.apis">
Review Comment:
The other tabs in this page are hidden when the user does not have
permission to list their contents. I don't see why the volumes tab should be an
exception.
Showing an empty list may lead users into thinking that the instance does
not have any volumes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
