BryanMLima commented on PR #8713:
URL: https://github.com/apache/cloudstack/pull/8713#issuecomment-1971658605

   Manually tested this, LGTM.
   
![image](https://github.com/apache/cloudstack/assets/42067040/2c5ab60e-ef2c-4ba8-9ce4-fab670835b6b)
   
   ---
   
   > > > tested works in qa, but note that also the whole storage tab in the 
main menu has disappeared: ![image](https://
   > > > was this intended @winterhazel ? (no snapshots/backups)
   > > 
   > > 
   > > @DaanHoogland the changes in this PR do not affect the storage tab in 
the main menu.
   > > There are two APIs for listing volumes: `listVolumesMetrics` (used in 
the volumes listing page) and `listVolumes` (used in the instance's page, where 
this PR is adding a check). I suppose that the storage tab disappeared for you 
because the access to `listVolumesMetrics` has been denied (this is the current 
behavior, which has not been affected by this PR).
   > 
   > Ok, this then is another bug, no storage page when rights to listBackups 
and listSnapshots do exist :(
   
   Regarding this situation I will create an issue, may even create a PR for 
this, as this should be an easy fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to