weizhouapache commented on code in PR #8809:
URL: https://github.com/apache/cloudstack/pull/8809#discussion_r1532034115
##########
server/src/main/java/com/cloud/consoleproxy/AgentHookBase.java:
##########
@@ -213,7 +213,7 @@ public void startAgentHttpHandlerInVM(StartupProxyCommand
startupCmd) {
byte[] ksBits = null;
String consoleProxyUrlDomain =
_configDao.getValue(Config.ConsoleProxyUrlDomain.key());
- String consoleProxySslEnabled =
_configDao.getValue("consoleproxy.sslEnabled");
+ String consoleProxySslEnabled =
_configDao.getValue(ConsoleProxyManager.ConsoleProxySslEnabled.key());
Review Comment:
@GutoVeronezi
this may not work as the `_configDao` is set in the constructor of the class.
```
protected AgentHookBase(VMInstanceDao instanceDao, HostDao hostDao,
ConfigurationDao cfgDao, KeystoreManager ksMgr,
AgentManager agentMgr, KeysManager keysMgr,
ConsoleAccessManager consoleAccessMgr) {
_instanceDao = instanceDao;
_hostDao = hostDao;
_agentMgr = agentMgr;
_configDao = cfgDao;
_ksMgr = ksMgr;
_keysMgr = keysMgr;
consoleAccessManager = consoleAccessMgr;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
