DaanHoogland commented on code in PR #8751:
URL: https://github.com/apache/cloudstack/pull/8751#discussion_r1551837537


##########
engine/components-api/src/main/java/com/cloud/template/TemplateManager.java:
##########
@@ -51,6 +51,11 @@ public interface TemplateManager {
     static final ConfigKey<Integer> TemplatePreloaderPoolSize = new 
ConfigKey<Integer>("Advanced", Integer.class, TemplatePreloaderPoolSizeCK, "8",
             "Size of the TemplateManager threadpool", false, 
ConfigKey.Scope.Global);
 
+    ConfigKey<Boolean> ValidateUrlIsResolvableBeforeRegisteringTemplate = new 
ConfigKey<>("Advanced", Boolean.class,
+            "validate.url.is.resolvable.before.registering.template", "true", 
"Indicates whether CloudStack "
+            + "will validate if the provided URL is resolvable during the 
register of templates/ISOs before persisting them in the database.",
+            true);

Review Comment:
   @winterhazel , this is now a global setting. Does it make sense to norrow 
the scope? 
   
   i.e. allow it only in specific zones/clusters, like dedicated ones?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to