winterhazel commented on code in PR #8751:
URL: https://github.com/apache/cloudstack/pull/8751#discussion_r1553603897
##########
engine/components-api/src/main/java/com/cloud/template/TemplateManager.java:
##########
@@ -51,6 +51,11 @@ public interface TemplateManager {
static final ConfigKey<Integer> TemplatePreloaderPoolSize = new
ConfigKey<Integer>("Advanced", Integer.class, TemplatePreloaderPoolSizeCK, "8",
"Size of the TemplateManager threadpool", false,
ConfigKey.Scope.Global);
+ ConfigKey<Boolean> ValidateUrlIsResolvableBeforeRegisteringTemplate = new
ConfigKey<>("Advanced", Boolean.class,
+ "validate.url.is.resolvable.before.registering.template", "true",
"Indicates whether CloudStack "
+ + "will validate if the provided URL is resolvable during the
register of templates/ISOs before persisting them in the database.",
+ true);
Review Comment:
@DaanHoogland I think it would make sense to have it management server
scoped, as its use-case comes from a management server specific configuration;
making it zone/cluster scoped does not make sense as the same management server
can manage multiple zones/clusters.
However, even though the `ManagementServer` scope type exists, its
implementation has not been made yet. I think we could implement it in a
separate PR and change this setting in the future, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
