rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1609919869
##########
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##########
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey<Boolean> SharePublicTemplatesWithOtherDomains = new
ConfigKey<>("Advanced", Boolean.class,
"share.public.templates.with.other.domains", "true",
"If false, templates of this domain will not show up in the list
templates of other domains.", true, ConfigKey.Scope.Domain);
+ ConfigKey<Boolean> ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "true",
Review Comment:
```suggestion
ConfigKey<Boolean> ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "false",
```
After due considerations, I think this can be set to false what originally
Joao wants to accomplish. As the listVirtualMachines API is used by at least
three integrations I know of (CAPC, k8s-provider and terraform etc.) and
several portals are built on top such APIs, it makes sense to trade off speed.
BUT, if we do this we must document this change in the release notes and what
users can do to get previous/old behaviour if they want it. This along with
setting the `vm.stats.increment.metrics` setting to false as well.
What do you think - @JoaoJandre @weizhouapache @DaanHoogland @sureshanaparti
@shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
