rohityadavcloud commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1627643622
##########
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##########
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey<Boolean> SharePublicTemplatesWithOtherDomains = new
ConfigKey<>("Advanced", Boolean.class,
"share.public.templates.with.other.domains", "true",
"If false, templates of this domain will not show up in the list
templates of other domains.", true, ConfigKey.Scope.Domain);
+ ConfigKey<Boolean> ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "true",
Review Comment:
We add the config for users who may want the backward compatibility. But we
use an appropriate default that benefits most users. Your comment makes sense
for the UI or somebody's scripts, but in large env. many integrations exists in
production that cannot be changed or people simply don't care to change them,
so it may not be possible for everyone to change them. For example, the k8s
provider or CAPC would call the list API; somebody using them (the end user)
can't change the list api params in them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
