weizhouapache commented on code in PR #8782:
URL: https://github.com/apache/cloudstack/pull/8782#discussion_r1611124410
##########
api/src/main/java/org/apache/cloudstack/query/QueryService.java:
##########
@@ -125,6 +125,10 @@ public interface QueryService {
static final ConfigKey<Boolean> SharePublicTemplatesWithOtherDomains = new
ConfigKey<>("Advanced", Boolean.class,
"share.public.templates.with.other.domains", "true",
"If false, templates of this domain will not show up in the list
templates of other domains.", true, ConfigKey.Scope.Domain);
+ ConfigKey<Boolean> ReturnVmStatsOnVmList = new ConfigKey<>("Advanced",
Boolean.class, "return.vm.stats.on.vm.list", "true",
Review Comment:
obviously users/other projects will benifit from the change, meanwhile it
will break the backward compatibility.
if we agree more pros than cons, let's go ahead.
as @rohityadavcloud said, we must document in the release note and let users
know (although many users might not be impacted and not be aware of the change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
