rg9975 commented on code in PR #8889:
URL: https://github.com/apache/cloudstack/pull/8889#discussion_r1622995215


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -266,10 +266,11 @@ public Answer copyTemplateToPrimaryStorage(final 
CopyCommand cmd) {
 
                 Map<String, String> details = primaryStore.getDetails();
 
-                String path = details != null ? 
details.get("managedStoreTarget") : null;
+                String path = derivePath(primaryStore, destData, details);
 
                 if 
(!storagePoolMgr.connectPhysicalDisk(primaryStore.getPoolType(), 
primaryStore.getUuid(), path, details)) {
                     s_logger.warn("Failed to connect physical disk at path: " 
+ path + ", in storage pool id: " + primaryStore.getUuid());
+                    return new PrimaryStorageDownloadAnswer("Failed to spool 
template disk at path: " + path + ", in storage pool id: " + 
primaryStore.getUuid());

Review Comment:
   This has been removed, not returning it appears to have no negative 
consequences on the Primera and Pure driver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to