FelipeM525 commented on code in PR #9132:
URL: https://github.com/apache/cloudstack/pull/9132#discussion_r1701861805


##########
server/src/test/java/com/cloud/vm/UserVmManagerTest.java:
##########
@@ -292,7 +292,7 @@ public void testScaleVMF1() throws Exception {
 
         
lenient().when(_vmInstanceDao.findById(anyLong())).thenReturn(_vmInstance);
 
-        // UserContext.current().setEventDetails("Vm Id: "+getId());
+        // UserContext.current().setEventDetails("VM ID: "+getId());

Review Comment:
   ```suggestion
           // UserContext.current().setEventDetails("VM Id: "+getId());
   ```



##########
plugins/network-elements/netscaler/src/main/java/com/cloud/api/commands/StopNetScalerVMCmd.java:
##########
@@ -110,7 +110,7 @@ public boolean isForced() {
 
     @Override
     public void execute() throws ConcurrentOperationException, 
ResourceUnavailableException {
-        CallContext.current().setEventDetails("NetScaler vm Id: " + getId());
+        CallContext.current().setEventDetails("NetScaler VM ID: " + getId());

Review Comment:
   ```suggestion
           CallContext.current().setEventDetails("NetScaler VM Id: " + getId());
   ```



##########
server/src/test/java/com/cloud/vm/UserVmManagerTest.java:
##########
@@ -402,7 +402,7 @@ public void testScaleVMF4() throws Exception {
         serviceOfferingIdField.setAccessible(true);
         serviceOfferingIdField.set(cmd, 1L);
 
-        //UserContext.current().setEventDetails("Vm Id: "+getId());
+        //UserContext.current().setEventDetails("VM ID: "+getId());

Review Comment:
   ```suggestion
           //UserContext.current().setEventDetails("VM Id: "+getId());
   ```



##########
plugins/network-elements/juniper-contrail/src/main/java/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java:
##########
@@ -134,7 +134,7 @@ private ServiceVirtualMachine createServiceVM(DataCenter 
zone, Account owner, Vi
         } catch (InsufficientCapacityException ex) {
             throw new CloudRuntimeException("Insufficient capacity", ex);
         }
-        CallContext.current().setEventDetails("Vm Id: " + svm.getId());
+        CallContext.current().setEventDetails("VM ID: " + svm.getId());

Review Comment:
   ```suggestion
           CallContext.current().setEventDetails("VM Id: " + svm.getId());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to