nvazquez commented on code in PR #9546:
URL: https://github.com/apache/cloudstack/pull/9546#discussion_r1722349605
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java:
##########
@@ -111,14 +109,7 @@ public String getStorageType() {
}
public State getState() {
- if (StringUtils.isBlank(diskOfferingState)) {
- return Active;
- }
- State state = EnumUtils.getEnumIgnoreCase(State.class,
diskOfferingState);
- if (!diskOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
Are these checks not relevant anymore?
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##########
@@ -157,14 +154,7 @@ public String getStorageType() {
}
public State getState() {
- if (StringUtils.isBlank(serviceOfferingState)) {
- return Active;
- }
- State state = EnumUtils.getEnumIgnoreCase(State.class,
serviceOfferingState);
- if (!serviceOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
