Pearl1594 commented on code in PR #9546:
URL: https://github.com/apache/cloudstack/pull/9546#discussion_r1722369998
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##########
@@ -157,14 +154,7 @@ public String getStorageType() {
}
public State getState() {
- if (StringUtils.isBlank(serviceOfferingState)) {
- return Active;
- }
- State state = EnumUtils.getEnumIgnoreCase(State.class,
serviceOfferingState);
- if (!serviceOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
I just made this uniform to how it works with listing network and vpc
offerings ; wherein when the state isn't passed, we list all offerings - so we
do not explicitly need "all"
##########
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java:
##########
@@ -111,14 +109,7 @@ public String getStorageType() {
}
public State getState() {
- if (StringUtils.isBlank(diskOfferingState)) {
- return Active;
- }
- State state = EnumUtils.getEnumIgnoreCase(State.class,
diskOfferingState);
- if (!diskOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
I just made this uniform to how it works with listing network and vpc
offerings ; wherein when the state isn't passed, we list all offerings - so we
do not explicitly need "all"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
