JoaoJandre commented on issue #10007: URL: https://github.com/apache/cloudstack/issues/10007#issuecomment-2508141897
> Hello, @luganofer and @iishitahere > > From what I remember of the code, the throttling is applied differently if the NIC of the VM is the default one or not. > > https://github.com/apache/cloudstack/blob/db2e89a3a2c9e8df2d24ed3e6aeae280bf22f0ba/server/src/main/java/com/cloud/network/NetworkModelImpl.java#L1037 > > For the default NIC, the network throttling is applied based on the compute offering network bandwidth of the VM. If there is no limit set in the compute offering, the value of the configuration `vm.network.throttling.rate` will be used. > > For additional NICs, the network throttling is applied based on the network offering bandwidth. If there is no limit set in the network offering, then the value of the configuration `network.throttling.rate` will be used. > > To be fair, this behavior is kind of confusing, and maybe a discussion should be done before any actual implementation. > > What do you guys think? cc @DaanHoogland @JoaoJandre @GutoVeronezi @weizhouapache You're correct on the throttling behavior @BryanMLima. I also think that this behavior is very unintuitive for users, the throttling should happen either only on the network offering or on the compute offering. Personally I think that only having the setting in the network offering makes more sense. However, we could also have a setting to determine if the throttle (for all NICs of a VM) will be based on the compute or the network offering. @iishitahere I would wait for some other opinions before implementing anything, if you're not familiar with ACS and its code, I would start by getting used to it. Once the way forward is established, I would start the actual code changes (this is just my opinion, feel free to ignore it). In any case, I think that the easiest way forward would be creating that configuration that I mentioned. Furthermore, for maximum configurability, we could eventually add a feature to allow configuring the throttling of each NIC of a given VM separately, regardless of offerings. I know that @hsato03 was working on this specific feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
